Re: [hackers] [slock] Fix my previous commit and some light refactoring

From: FRIGN <>
Date: Thu, 1 Sep 2016 13:56:24 +0200

On Thu, 1 Sep 2016 13:45:24 +0200
Quentin Rameau <> wrote:

Hey Quentin,

> My last commit removing the input grabbing waiting loop was a mistake,
> I tested it on a specific setup which didn't raise any error while
> regular setups should do.
> So the second of the four next commits fixes that.
> The other three try to move duplicated behaviour inside unique
> functions and move global variables inside functions which
> exclusively need them. Patches following.

the patches look good to me and I would favor them to be merged.
Thanks for your work, Quentin!



Received on Thu Sep 01 2016 - 13:56:24 CEST

This archive was generated by hypermail 2.3.0 : Thu Sep 01 2016 - 14:00:21 CEST