Re: [hackers] [sbase] [patch] ed: standards compliance, manpage, double free and infinite loop fix

From: Laslo Hunhold <>
Date: Sun, 9 Oct 2016 21:25:11 +0200

On Thu, 6 Oct 2016 11:04:17 +0000
Thomas Mannay <> wrote:

Hey Thomas,

> Resubmission of my patchset for ed, albeit much better formatted so
> as to ease reading them.

as promised, I will give you some feedback on your patches you sent in.

### 0001-ed-newly-joined-lines-are-placed-correctly.patch

- change the name to "ed: place newly-joined lines correctly"
- the code within join() is not tab- but space-indented
- can getindex(curln-1) underflow? (if curln = 0)
- what's the purpose of the free(s)?

### 0002-ed-if-only-one-address-is-given-to-j-do-nothing.patch

### 0003-ed-fix-double-free-and-infinite-loop-in-join.patch

- can you give an example in the patch-description where this
  infinite loop occurs?

### 0004-ed-wrote-manpage.patch

- change the name to "ed: add a manpage"
- Do we really need an "EXTENDED DESCRIPTION"
- Please check the other manpages for the standard format of
  the STANDARDS section

Thanks for your submissions!



Laslo Hunhold <>
Received on Sun Oct 09 2016 - 21:25:11 CEST

This archive was generated by hypermail 2.3.0 : Sun Oct 09 2016 - 21:36:15 CEST