Re: [hackers] [PATCH] [ubase] dd: Use sigaction(2) to obviate select(2)

From: Eric Pruitt <eric.pruitt_AT_gmail.com>
Date: Sun, 10 Sep 2017 04:24:36 -0700

On Sun, Sep 10, 2017 at 11:55:53AM +0100, Richard Ipsum wrote:
> This isn't a comment on this patch exactly, since this call exists in
> the existing handler, but unless I'm missing something about the way
> you're doing this it isn't safe to call fprintf in a signal handler
> since your signal may be interrupting an fprintf call itself, and
> since the data structures for stdio aren't reentrant, things will get
> messy.

I personally don't think there's any benefit in displaying the message
at all. I'll post a revised patch since moving the warning is trivial,
and it'll give me a chance to fix my botched commit message.

Eric
Received on Sun Sep 10 2017 - 13:24:36 CEST