Re: [hackers] [sbase][PATCH] libutil/random: better random seed

From: NRK <nrk_AT_disroot.org>
Date: Wed, 6 Mar 2024 07:18:03 +0000

> - *state = ts.tv_nsec;
> + *state = (intptr_t)&printf ^ time(NULL) ^ (ts.tv_nsec * 0xAC5533CD);

tv_nsec is `long` which is signed. Signed interger overflow is
undefined. You need to cast it to `unsigned long` before multiply:

        ... ^ ((unsigned long)ts.tv_nsec * 0xAC5533CD)

- NRK
Received on Wed Mar 06 2024 - 08:18:03 CET