[hackers] [st][PATCH] Don't configure the font pattern twice

From: Sergei Grechanik <sergei.grechanik_AT_proton.me>
Date: Sat, 07 Sep 2024 21:42:15 +0000

This patch removes the second call to FcConfigSubstitute in xmakeglyphfontspecs.
This call shouldn't be required because FcConfigSubstitute is already called in
xloadfont. Configuring the same pattern twice may lead to font fallback issues,
see [1] for details.

[1]: https://lists.suckless.org/dev/2406/35635.html

---
 x.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/x.c b/x.c
index d73152b..5aa63e0 100644
--- a/x.c
+++ b/x.c
_AT_@ -1333,8 +1333,6 @@ xmakeglyphfontspecs(XftGlyphFontSpec *specs, const Glyph *glyphs, int len, int x
 					fccharset);
 			FcPatternAddBool(fcpattern, FC_SCALABLE, 1);
-			FcConfigSubstitute(0, fcpattern,
-					FcMatchPattern);
 			FcDefaultSubstitute(fcpattern);
 			fontpattern = FcFontSetMatch(0, fcsets, 1,
--
2.43.0

Received on Sat Sep 07 2024 - 23:42:15 CEST