Re: [dev] pertag + galpessgrid patch together

From: Bartosz Nitkiewicz <bartosz.nitkiewicz_AT_dziq.pl>
Date: Sun, 8 Nov 2009 14:02:36 +0100

So, the solution is not to use pertag with other patches becouse one excludes the other.
On 08 Nov 09 at 11:35 +0000, Aled Gest wrote:
> It seems the issue is caused by the fact that the pertag patch moves
> the definition of the 'Monitor' struct to after config.h is included.
>
> The pertag patch modifies the 'Monitor' struct in a way that depends
> on 'tags' being already defined and thus has to defined after config.h
> is included. This creates an obvious conflict with the method of
> including extra functions in config.h when those functions make use of
> the 'Monitor' struct.
>
> 2009/11/8 Aled Gest <himselfe_AT_gmail.com>:
> > 2009/11/8 Szabolcs Nagy <nszabolcs_AT_gmail.com>:
> >> don't do that
> >> include the .c files in the appropriate place in config.h instead (eg
> >> right before layouts)
> >
> > That's what he's doing, that's where the problem is...
> >
> > There seems to be a bug when some patches are applied that prevents
> > functions included from within config.h from compiling.
> >
> > I made that suggestion as a quick fix in case he just wanted to get it
> > working. It's a perfectly valid solution, and since he would be
> > modifying his own copy of dwm and not submitting code to the vanilla
> > distribution it's not going to harm anybody.
> >
>

Received on Sun Nov 08 2009 - 13:02:36 UTC

This archive was generated by hypermail 2.2.0 : Sun Nov 08 2009 - 13:12:02 UTC