Re: [dev] [dmenu] vertical list bugs and patch

Hi,

thanks I applied your patch.

As a remark: The plan is to remove the cursor handling from dmenu
again, since it violates the single purpose idea of dmenu. Instead
there will be a dinput or sinput program that basically is nothing
else as a text field widget that prints the input to standard out.
With this one can achieve the current dmenu behavior like this

dmenu < $HOME/.dmenu/urls || dinput >> $HOME/.dmenu/urls

(if something isn't in the list, one presses ESC in dmenu and enters
the new entry using the popping up dinput)

Cheers,
Anselm

On 7 March 2010 00:13, Connor Lane Smith <cls_AT_lubutu.com> wrote:
> Hey all,
>
> I found dmenu tip to have a couple of bugs wrt vertical menus:
>  - the '-l' flag adds to the default number of lines, instead of replacing it.
>  - there is no cursor in vline mode.
>
> The attached patch fixes these two problems and sorts out the code a
> little, reducing the LOC by 11. If it doesn't suck too much hopefully
> it could be added to tip?
>
> Thanks,
> cls
>
Received on Sun Mar 07 2010 - 08:35:46 UTC