Re: [dev] dwm-5.8.1 / dmenu-4.1.1

On Sun, May 30, 2010 at 10:07:00AM +0100, Anselm R Garbe wrote:
>On 29 May 2010 22:18, Sylvain Laurent <syllaur_AT_gmail.com> wrote:
>> Yes, that's what I was thinking about EWMH, there is already monocle
>> mode to set full screen on the user's end, by not maximizing windows
>> when sending hint to the window it allows users to play with
>> monocle/floating/tiles mode.
>
>I spend some time on the fullscreen issues and came up with a version
>that works for all cases I tested so far. It is committed into hg tip.
>It is a simplification of Kris' patch (basically I got rid of
>superflous checks that don't seem to be necessary), but with a more
>complicated clientmessage(). I also extended Client a bit to keep
>state and changed resize(). The changes I did are backwards compliant
>for any layout algorithms however.

Your version is much cleaner. As for the checks, I went and
rechecked the spec, and it is a SHOULD rather than a MUST. It's
mainly intended for restarting/changing window managers, so
unless something is broken without it, I think it should be left
out.

-- 
Kris Maglione
The string is a stark data structure and everywhere it is passed there
is duplication.  It is a perfect vehicle for hiding information.
	--Alan J. Perlis