Re: [dev] Re: dwm puzzle [fixed; with blame]

On Sun, Sep 12, 2010 at 11:24:23AM +0200, Szabolcs Nagy wrote:
> * Peter John Hartman <peterjohnhartman_AT_gmail.com> [2010-09-11 15:23:18 -0400]:
> > This fixes it:
> >
> > diff -r 050d521d66d8 -r c361034c5a1c dwm.c
> > --- a/dwm.c Tue Aug 24 13:13:20 2010 +0100
> > +++ b/dwm.c Sat Sep 11 19:00:18 2010 +0000
> > @@ -799,7 +799,7 @@
> > unfocus(selmon->sel, True);
> > selmon = m;
> > }
> > - focus(wintoclient(ev->window));
> > + focus((wintoclient(ev->window)));
> > }
> >
> > But evidently that's odd.
> > gcc version 4.4.3 (Gentoo 4.4.3-r2 p1.2)
> >
> > I use the default config.mk (without XINERAMA stuff) and config.h.
> >
> > In any case, that fixes the bug and now openoffice and firefox behave.
> >
> > Thoughts?
> > Peter
>
> can you please add -S to CFLAGS and send the diff -u of the resulting
> dwm.s in the parenthesis vs no parenthesis case?
>
> i'm interested in the problem
>

Ok, I haven't done this yet, but a little update. It turns out that this
patch /didn't/ fix the problem; or, at least, it partially did. On
occasion, firefox at least and mplayer in full screen mode will not
behave. It is something intermittent as far as I can tell. I should
not that it still remains true that this never happened in 5.8.2.
(It never happened that I recall; and I've been running 5.8.2 since
last night when it happened again in hg tip and so far it has not
yet happened.)

Peter
Received on Sun Sep 12 2010 - 16:52:12 CEST