Re: [dev] [dwm] Button ClkStatusText + xinerama

Hello,

I just tried to change this part of the code:

diff -r ba590e72eb2a dwm.c
--- a/dwm.c Sat May 21 20:26:26 2011 +0100
+++ b/dwm.c Thu May 26 14:33:45 2011 +0200
@@ -442,7 +442,7 @@
                 }
                 else if(ev->x < x + blw)
                         click = ClkLtSymbol;
- else if(ev->x > selmon->wx + selmon->ww - TEXTW(stext))
+ else if(ev->x > selmon->ww - TEXTW(stext))
                         click = ClkStatusText;
                 else
                         click = ClkWinTitle;

And it seems ok now. I am able to click on the status text as expected in
xinerama with 2 screens.
(so maybe the selmon->ww refers from the left of the xinerama and not just of
the screen???)

Do you think this patch could have a side effect?
And if it is ok, could you add this for the next release?

Thanks,
capitn

On Thu, 28 Apr 2011 12:35:59 +0000
Anselm R Garbe <anselm_AT_garbe.us> wrote:

> Hi,
>
> On Thu, Apr 28, 2011 at 02:32:47PM +0200, Nicolas Capit wrote:
> > I configured dwm (5.9) with something like this in config.h:
> >
> > static Button buttons[] = {
> > /* click event mask button function argument */
> > { ClkStatusText, 0, Button1, spawn, {.v = (const char*[]){"xclock", NULL}} },
> > ...
> >
> > Everything works fine with 1 screen: When I click on the status text then a
> > xclock appears.
> >
> > If I plug another screen to my configuration with xinerama config then this
> > behaviour works only on the first screen. If I click on the status text (when
> > it is displayed) on the second screen then it is like I click on the window
> > title (ClkWinTitle); no xclock.
> >
> > I think there is something to do at line 446 of dwm.c to calculate the right
> > position of the status text in xinerama but I am not sure.
> >
> > else if(ev->x > selmon->wx + selmon->ww - TEXTW(stext))
> > click = ClkStatusText;
> >
> > If someone can take a look at this part of the code it will be great :-)
>
> Thanks for reporting. Will look into this.
>
> Thanks,
> Anselm
>
>
Received on Thu May 26 2011 - 14:39:57 CEST