Re: [dev] [dwm] Button ClkStatusText + xinerama

Hi,

On 26 May 2011 13:39, Nicolas Capit <capitn_AT_free.fr> wrote:
> I just tried to change this part of the code:
>
> diff -r ba590e72eb2a dwm.c
> --- a/dwm.c     Sat May 21 20:26:26 2011 +0100
> +++ b/dwm.c     Thu May 26 14:33:45 2011 +0200
> @@ -442,7 +442,7 @@
>                }
>                else if(ev->x < x + blw)
>                        click = ClkLtSymbol;
> -               else if(ev->x > selmon->wx + selmon->ww - TEXTW(stext))
> +               else if(ev->x > selmon->ww - TEXTW(stext))
>                        click = ClkStatusText;
>                else
>                        click = ClkWinTitle;
>
> And it seems ok now. I am able to click on the status text as expected in
> xinerama with 2 screens.
> (so maybe the selmon->ww refers from the left of the xinerama and not just of
> the screen???)
>
> Do you think this patch could have a side effect?

Yes, it will only work in your case, in some cases the existing code
will work, but both aren't fully correct, because we don't normalize
the monitor array from left to right and top to down properly. This is
what I will fix now.

> And if it is ok, could you add this for the next release?

The code you changed is only working in your particular case, the real
problem is the lack of proper direction handling (left-of, top-of,
etc).

I will think carefully about this multiscreen insanity :) I'm a bit
tempted to make it a lot simpler...

Cheers,
--garbeam
Received on Sat Jun 11 2011 - 09:32:21 CEST