Re: [dev][dwm] Floating window center position fix

Hi lolilolicon,

On 20 July 2011 17:53, lolilolicon <lolilolicon_AT_gmail.com> wrote:
> I have a rule in config.h for MPlayer to always float. The bug was
> observed when I played a 720p video whose window was 1280 pixels so it
> filled the width of my laptop screen. The MPlayer window was supposed to
> be centered, but a border line on the left was clearly visible. For
> further confirmation, I set borderpx to 20. My observation was obviously
> right. The patch is appended at the end.

Thanks, applied.

> Another thing I've observed but didn't care to fix when playing the video:
> If the MPlayer window is always created in tag 4 (as per a rule), but I
> run the mplayer command in xterm in tag 1, the visibility of the MPlayer
> window border depends on some timing:
>
> 1) If I switch from tag 1 to tag 4 _after_ the MPlayer window is created,
>   the border is visible.
> 2) If I switch from tag 1 to tag 4 _before_ the MPlayer window is created,
>   the border is invisible. It seems for dwm the border exists, just not
>   drawn. If I switch to another tag and back, or do a focusstack()
>   using the default mod1+j combo or pretty about anything, the border
>   will then be drawn.
>
> Relevant entries in my test config.h are:
>
> static const unsigned int borderpx = 20;
> static const Rule rules[] = {
>  { "MPlayer", NULL, NULL, 1 << 3, True, -1 },
> };

Thanks for your bug report, this needs further investigation.

Cheers,
Anselm
Received on Wed Jul 20 2011 - 20:34:25 CEST