Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode

Hi Peter,

On 11 July 2011 01:02, Peter John Hartman <peterjohnhartman_AT_gmail.com> wrote:
> Actually, this bug goes way back, but I thought I'd be the first to report
> it, just to ruin dwm's birthday.  The culprit is this chunk of code in
> manage():
>
>        if(c->w == c->mon->mw && c->h == c->mon->mh) {
>                // c->isfloating = True; pjh
>                c->x = c->mon->mx;
>                c->y = c->mon->my;
>                c->bw = 0;
>        }
>
> Commenting out that line fixes it.
>
> How you reproduce it is the fun bit.
>
> (1) You have to have borderpx set to 0.
> (2) You have to be in monocle mode.
> [(3) You might also have to have statusbar hidden.]
> (4) Open up a couple of apps.
>
> Now, hit MODKEY+Shift+q, provided you have the dwm loop thing in your
> .xinitrc.  The windows all come back in floating mode, lovely enough.

Thanks for spotting. I applied it despite the fullscreen rework plans for now.

> Current discussion on the mailing list is leaning to just eliminating that
> chunk of code.  Apparently, flash fullscreen requires it (which I haven't
> been able to reproduce!)  But why on earth is that code there, and can't
> flash fullscreen be handled via a Rule?

I need to investigate when I added this chunk of code to remember why :)

Cheers,
--garbeam
Received on Wed Jul 20 2011 - 20:39:09 CEST