Re: [dev] [st] Shift Tab does not work

From: Benjamin R. Haskell <>
Date: Thu, 13 Dec 2012 07:31:24 -0500 (EST)

On Thu, 13 Dec 2012, Roberto E. Vargas Caballero wrote:

>> Looking in the repository I can see that the commit 16ccf (Fix tab
>> key) inserted this code, and I have tested that is such commit it was
>> working, so we have a regression. I am going try now a bisection and
>> try locate which commit broken this key.
> The bisect indicates that the commit whichs performs the regression is
> 2b652 (Optimizing the key lookup to the X11 function key), Which does
> that if the event is smaller than 0xFF00, then the lookup is not
> performed, but how we can see in keysymdef.h:
> #define XK_ISO_Left_Tab 0xfe20
> So the solution is modify the line 2731 of st.c (if((k & 0xFFFF) < 0xFF00)).
> I will send a patch soon for this issue.

This can be fixed by changing in config.{,def.}h:

-static KeySym mappedkeys[] = { -1 };
+static KeySym mappedkeys[] = { XK_ISO_Left_Tab };

But, it's error-prone to have two places to keep track of what keys get
mapped. So, I fixed this for myself a while ago by removing mappedkeys
entirely. Patch attached.


Received on Thu Dec 13 2012 - 13:31:24 CET

This archive was generated by hypermail 2.3.0 : Thu Dec 13 2012 - 13:36:04 CET