Re: [dev] [dwmstatus] Mail counter

From: Kurt Van Dijck <kurt.van.dijck_AT_eia.be>
Date: Fri, 21 Dec 2012 21:22:55 +0100

Hi,

a) I would have put your username & Mail folder as parameters,
   argv[1] & argv[2] or so.
b) man 3 asprintf
   will eliminate 1/3 of your code
c) you seem to have 2 coding styles mixes together: tabs vs. 4 spaces.

I don't care about your French, although I think your comments that are in
French are pointless. Next step is using git or similar ...

Kurt

On Fri, Dec 21, 2012 at 04:57:43PM +0100, Xavier Cartron wrote:
> Hello,
> I tried my first piece of C into adding a mail counter to dwmstatus.
> The code is added on the wiki [1]
>
> Please correct my mistakes.
>
> Regards,
>
> [1] http://dwm.suckless.org/dwmstatus/mail_counter.c
> --
> ,--. Xavier Cartron
> : /` ) M2 MEFPC
> | `-' Debian user
> \_ jabber : thuban_AT_jabber.fr
>
Received on Fri Dec 21 2012 - 21:22:55 CET

This archive was generated by hypermail 2.3.0 : Fri Dec 21 2012 - 21:24:04 CET