Greetings.
On Tue, 19 Feb 2013 15:54:06 +0100 Alexander Sedov <alex0player_AT_gmail.com> wrote:
> This patch adds support for rectangular selections a-la urxvt, which come
> in handy when using applications like irssi or mcabber.
You are commenting out code and leave it there without any notice, if it
should be reused later. Next you are using a different style than the st
style, which means you use »if (« instead of »if(«. The same applies for
the switch case and the simple if clause, which should be
if() {
} else {
}
If that’s fixed your patch will be applied. The hard case why I’m not
applying it and notice you is because of commenting out the code. That’s
unclean.
Sincerely,
Christoph Lohmann
Received on Tue Feb 19 2013 - 15:54:06 CET