Re: [dev] [DWM] Patch: stack mfact

From: Raphael Proust <raphlalou_AT_gmail.com>
Date: Wed, 27 Mar 2013 14:41:34 +0000

On Wed, Mar 27, 2013 at 1:17 PM, Jente Hidskes <jthidskes_AT_outlook.com> wrote:
> You're right - I should not have submitted the patch with a bug that would
> crash DWM. However, it was only with seven clients or more and as I rarely
> have more than 3 open at once, for me it wasn't that big of an issue. I have
> now fixed it, though. I did that by having setsmfact() check the amount of
> clients and have it set an appropriate limit. It still crashes, but this
> time it only this when you have 30 or more clients in your stack which I
> think is highly unlikely and thus, a save approach. If you really want to
> eliminate the crashing, you would have to have tile() report the height of
> the clients in the stack and if(h < MIN_WIN_SIZE) then do something.

Hmm… Most times I only use a (very) limited number of clients. From time to
time though I do

for i in *.pdf
do
llpp $i &
done

and then kick the st window out of the way (on a trash tag) before making my
way through all of those pdf documents.

Don't know how common this is. And there might be a better way to do it.


>
> I have attached the new version. Again, I look forward to hearing your
> feedback!

You can make patches public by cloning the website repo
(http://git.suckless.org/sites/), adding a page for your patch and pushing
the changes.


Cheers,
-- 
______________
Raphaël Proust
Received on Wed Mar 27 2013 - 15:41:34 CET

This archive was generated by hypermail 2.3.0 : Wed Mar 27 2013 - 15:48:05 CET