[dev] [PATCH] Fix selecting clearing and BCE

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Tue, 23 Apr 2013 20:34:52 +0200

From: "Roberto E. Vargas Caballero" <k0ga_AT_shike2.com>

The commit b78c5085f72 changed the st behaviour enabling BCE capability,
that means erase regions using background color. Problem comes when you
clear a region with a selection, because in this case the real mode of the
Glyph is not the value of term.line[y][x], due in drawregion we had enabled
the ATTR_REVERSE bit.

---
 st.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/st.c b/st.c
index f593302..b8b6f56 100644
--- a/st.c
+++ b/st.c
_AT_@ -1409,7 +1409,7 @@ tsetchar(char *c, Glyph *attr, int x, int y) {
 
 void
 tclearregion(int x1, int y1, int x2, int y2) {
-	int x, y, temp;
+	int x, y, temp, mask;
 
 	if(x1 > x2)
 		temp = x1, x1 = x2, x2 = temp;
_AT_@ -1424,7 +1424,9 @@ tclearregion(int x1, int y1, int x2, int y2) {
 	for(y = y1; y <= y2; y++) {
 		term.dirty[y] = 1;
 		for(x = x1; x <= x2; x++) {
+			mask = selected(x, y) ? ATTR_REVERSE : 0;
 			term.line[y][x] = term.c.attr;
+			term.line[y][x].mode ^= mask;
 			memcpy(term.line[y][x].c, " ", 2);
 		}
 	}
-- 
1.7.10.4

Received on Tue Apr 23 2013 - 20:34:52 CEST