Re: [dev] [PATCH] Fix selecting clearing and BCE

From: <random832_AT_fastmail.us>
Date: Tue, 23 Apr 2013 15:38:32 -0400

On Tue, Apr 23, 2013, at 14:34, Roberto E. Vargas Caballero wrote:
> From: "Roberto E. Vargas Caballero" <k0ga_AT_shike2.com>
>
> The commit b78c5085f72 changed the st behaviour enabling BCE capability,
> that means erase regions using background color. Problem comes when you
> clear a region with a selection, because in this case the real mode of
> the
> Glyph is not the value of term.line[y][x], due in drawregion we had
> enabled
> the ATTR_REVERSE bit.

I don't understand the issue. How is this desired behavior? It looks
like your change makes it toggle the _real_ ATTR_REVERSE bit on the
selected region, making the selection appear to vanish, and it'll end up
in the wrong colors once the selection is actually removed.
Received on Tue Apr 23 2013 - 21:38:32 CEST