Re: [dev] [st] minor fix

From: Strake <strake888_AT_gmail.com>
Date: Mon, 6 May 2013 06:26:56 -0500

On 06/05/2013, Johannes Hofmann <johannes.hofmann_AT_gmx.de> wrote:
> Hi,
>
> there is a small glitch in the error handling of the select() call
> in st.c. See patch below.
>
> Regards,
> Johannes
>
> diff --git a/st.c b/st.c
> index 5251e70..689de26 100644
> --- a/st.c
> +++ b/st.c
> _AT_@ -3481,7 +3481,7 @@ run(void) {
> FD_SET(cmdfd, &rfd);
> FD_SET(xfd, &rfd);
>
> - switch(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv) < 0) {
> + switch(select(MAX(xfd, cmdfd)+1, &rfd, NULL, NULL, tv)) {
> case -1:
> if(errno == EINTR)
> continue;
>

Why are we even using switch here?
Received on Mon May 06 2013 - 13:26:56 CEST