Re: [dev] [sbase] [patch] Knock off a bunch of easy commands

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Thu, 30 May 2013 22:27:16 +0200

Greetings.

On Thu, 30 May 2013 22:27:16 +0200 "Galos, David" <galosd83_AT_students.rowan.edu> wrote:
> > Thanks foe the patch, but please learn to use whitespaces. I had to
> > reindent your whole patch.
> I apologize for the extra effort on your part; if I had known there
> was a whitespace problem, I would have been happy to fix it and
> resubmit.
>
> Could you be a bit more specific about the whitespace problems I was
> introducing? vim-ing around seemed to indicate that tabs used rather
> than spaces. Were there spaces mixed with tabs? This may be a vim
> issue on my side. Am I not spacing correctly around conditionals? I'm
> going off of plan9 style with modifications where I've seen
> corrections in the changelogs.
>
> I'll certainly fix this in env, who, chroot, id, and split before I submit them.

#include_<something.h>

for(i_=_0;_i_<_10;_i++)_{

'_' signals where you mostly forgot to include whitespaces and where this
reduced redability.

void
usage(*void*)\n
{

Functions in sbase mostly use this function declaration style.


Sincerely,

Christoph Lohmann
Received on Thu May 30 2013 - 22:27:16 CEST