Re: [dev] [sbase] [patch v2] Add strings(1)

From: sin <sin_AT_2f30.org>
Date: Thu, 15 Aug 2013 11:52:15 +0300

On Thu, Aug 15, 2013 at 10:44:51AM +0200, Roberto E. Vargas Caballero wrote:
> > + buf[i] = '\0';
> > + printf("%8ld: %s\n", (long)offset - i - 1, buf);
>
>
> I can see you are also printing the offset of the string in the file. It
> seems a bit strange to me, when by default strings output format is only the
> string detected [1], and it is the way that I usually use it.
>
>
>
> [1] http://pubs.opengroup.org/onlinepubs/009604499/utilities/strings.html

Yeah I should have mentioned, my implementation mirrors strings from
Plan9. My understanding is that sbase is not necessarily posix compliant.

Personally I'm used to this implementation. If you guys think it makes
more sense to switch to the standard output then I can do that.

Thanks,
sin
Received on Thu Aug 15 2013 - 10:52:15 CEST

This archive was generated by hypermail 2.3.0 : Thu Aug 15 2013 - 11:00:09 CEST