Re: [dev] [sbase] Portability of chvt

From: sin <sin_AT_2f30.org>
Date: Thu, 15 Aug 2013 15:00:18 +0300

GOn Thu, Aug 15, 2013 at 12:21:17AM +0300, sin wrote:
> On Wed, Aug 14, 2013 at 05:09:42PM -0400, Calvin Morrison wrote:
> > On 14 August 2013 14:12, Roberto E. Vargas Caballero <k0ga_AT_shike2.com> wrote:
> > > Hello,
> > >
> > > I was testing some of the tools of sbase, and after
> > > trying chvt I could see that it inserts directly in the code
> > > the ioctl values of linux, without including the header of
> > > the linux kernel. The problem comes when you try it with other
> > > operating system. You don't get any compilation problem,
> > > but it doesn't work and it is really dangerous (maybe in
> > > the other operating system this ioctl values do bad things).
> > >
> > > I think should be some control about what applications
> > > are built in each plataform, or even discuss if non portable
> > > applications should be in sbase.
> > >
> >
> > IIRC portability has been discussed previously. I would look through
> > the mailing archives
> >
> > Calvin
>
> I'd be inclined to put this in ubase[1]. sbase should be clear of
> non-portable code.

I cherry-picked this over to ubase (with slight modifications to remove
the unneeded enum and include linux/vt.h and linux/kd.h).
Received on Thu Aug 15 2013 - 14:00:18 CEST