Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

From: Roberto E. Vargas Caballero <>
Date: Wed, 2 Oct 2013 22:21:07 +0200

> Maybe I talked too much fast, and maybe we don't have to echo all the things
> we write to the tty with ttywrite. Let's me test it with some emulators and
> with my real terminal. I will send the results.

865: ttywrite(buf, len);
3459: ttywrite("\033[I", 3);
3464: ttywrite("\033[O", 3);

        I cannot report them because I have never used them and I don't know
        how I can generate them.

881: ttywrite(mk->s, strlen(mk->s));

        It is a shortcut for a mouse event, so maybe you want
        a string is inserted in a mouse event, so it must be echo'ed.

1018: ttywrite("\033[200~", 6);
2078: ttywrite(buf, len);
2466: ttywrite(VT102ID, sizeof(VT102ID) - 1);
1948: ttywrite(VT102ID, sizeof(VT102ID) - 1);
1021: ttywrite("\033[201~", 6);

        They are not echo'ed, and they shouldn't be, because it is information
        for a listener program, not for the user.

1019: ttywrite((const char *)data, nitems * format / 8);

        I have tested in other emulators and they seem don't echo
        them, but I think they should do it, because it must be transparent
        to the user if the new characters were typed in a keyborad or pasted.
3583: ttywrite(buf, len);

        It is the usual case when a user type something in the keyboard,
        so it must be echo'ed.

Roberto E. Vargas Caballero
Received on Wed Oct 02 2013 - 22:21:07 CEST

This archive was generated by hypermail 2.3.0 : Wed Oct 02 2013 - 22:24:06 CEST