Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

From: Roberto E. Vargas Caballero <>
Date: Wed, 2 Oct 2013 19:49:22 +0200

> > I think it might be a good idea to move
> > ttywrite();if(MODE_ECHO)techo() into its own function. It also appears
> > in bpress().
> >
> I agree, because always we call to ttywrite we should check the echo flag,
> and there are some places where it is not true (for example in mousereport).
> When I added echo mode the only one call was in kpress, but some later
> additions broke the mode. Moving the test into ttywrite is the correct
> way now that we have 11 calls to it. If you write a patch, please remove the
> stupid casting in:

Maybe I talked too much fast, and maybe we don't have to echo all the things
we write to the tty with ttywrite. Let's me test it with some emulators and
with my real terminal. I will send the results.

Best regards,

Roberto E. Vargas Caballero
Received on Wed Oct 02 2013 - 19:49:22 CEST

This archive was generated by hypermail 2.3.0 : Wed Oct 02 2013 - 20:00:09 CEST