Re: [dev] [sbase] [patch] Add primitive du(1)

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Wed, 16 Oct 2013 19:12:06 +0200

> Moving main() to the bottom and usage() to the top would eliminate the
> need to declare them.
I agree here.

>
> Functions push() and pop() seem to only be used once each.
> Would it be too bad to have these few lines directly in the du function?

I don't agree here, because I think the code is more clear with them.

Best regards,

-- 
Roberto E. Vargas Caballero
_______________________________________________________________________
'Write programs that do one thing and do it well. Write programs to work
together. Write programs to handle text streams, because that is a
universal interface'
(Doug McIlroy)
In Other Words - Don't design like polkit or systemd
_______________________________________________________________________

Received on Wed Oct 16 2013 - 19:12:06 CEST