Re: [dev] [sbase] [patch] Add primitive du(1)

From: Truls Becken <truls.becken_AT_gmail.com>
Date: Wed, 16 Oct 2013 18:47:26 +0200

A few trivial comments:

Moving main() to the bottom and usage() to the top would eliminate the
need to declare them.

Functions push() and pop() seem to only be used once each.
Would it be too bad to have these few lines directly in the du function?

The switch in du would be slightly simpler as an if statement I think.

Why not use eprintf for the opendir error?

-Truls
Received on Wed Oct 16 2013 - 18:47:26 CEST