Re: [dev] [PATCH] dmenu: Fix segfault on systems with broken locale support

From: Martti Kühne <mysatyre_AT_gmail.com>
Date: Thu, 21 Nov 2013 09:19:58 +0100

On Mon, Nov 18, 2013 at 8:15 PM, Ismael Luceno <ismael.luceno_AT_gmail.com> wrote:
>

uh. why not call XOpenIM() only after setlocale(LC_ALL, ""); first,
like you have to do with ncurses?
Because that would not require you to set the "C" locale at all, as
it's also not the case with st.

In st, we do something similar, only there the setlocale call is
limited to LC_CTYPE even. I didn't look further into the issue, it's
just that there locale handling seems to be done in an even messier
way with XSetLocaleModifiers() calls all over the place. I guess it
would be nice if we had some cleaned up x initialisation in drw.c that
deals with these things without greeting its creators early.

cheers!
mar77i
Received on Thu Nov 21 2013 - 09:19:58 CET