Re: [dev] [st][PATCH] Prevent resizing stdin

From: Eon S. Jeon <esjeon_AT_hyunmu.am>
Date: Tue, 17 Dec 2013 12:45:38 -0500

On Tue, 17 Dec 2013 12:41:01 -0500
"Eon S. Jeon" <esjeon_AT_hyunmu.am> wrote:

>
> Hello,
>
> This fixes a bug that the parent tty gets resized whenever you launch
> st through command line.
>
> The problem was that ioctl was resizing cmdfd before it gets
> initialized in ttynew. Since cmdfd is a global variable, its initial
> value is 0, and consequently stdin was being resized.
>

Urgh, sorry for an incomplete mail. I pressed a wrong hotkey...
Here's my patch:


diff --git a/st.c b/st.c
index f883ac1..4fb3311 100644
--- a/st.c
+++ b/st.c
_AT_@ -3667,11 +3667,11 @@ run(void) {
                 }
         }
 
+ ttynew();
         if(!xw.isfixed)
                 cresize(w, h);
         else
                 cresize(xw.fw, xw.fh);
- ttynew();
 
         gettimeofday(&lastblink, NULL);
         gettimeofday(&last, NULL);
Received on Tue Dec 17 2013 - 18:45:38 CET