Re: [dev] Announcing sinit - the suckless init

From: sin <sin_AT_2f30.org>
Date: Fri, 7 Feb 2014 21:36:01 +0000

On Fri, Feb 07, 2014 at 09:56:17PM +0100, Eckehard Berns wrote:
> I tested v0.3 and besides some glitches due to my system everything
> worked fine. I'm using fgetty (yeah, freeing a couple more kb might
> not be worth using it, but I tried it some time ago and kept it) and
> it complains about file descriptor 3 when I try to log in. Aparently
> (haven't checked the fgetty code) it uses file descriptor 3 for internal
> communication of some sort and that would be sinit's sigfd. I added
> a line to spawn() to close sigfd in the first child (if sigfd >= 0)
> and I could log in again.

I use SFD_CLOEXEC now - should work.

> Speaking of children, I think you could drop the double fork in spawn
> now, since pid 1 already waits for children.

Done.
Received on Fri Feb 07 2014 - 22:36:01 CET