Re: [dev] [dwm][patch] Executing key bindings on key release

From: Chris Down <>
Date: Wed, 26 Feb 2014 10:47:26 +0800

On 2014-02-25 21:52:37 +0100, Niklas Høj wrote:
> Duly noted. I can't help but wonder, though: would it not be more
> intuitive to have patches applied to the configuration that an install
> actually uses? Why not have a "config.h" in the repository?

Because config.def.h sets out the format for the configuration, which is
changed by your patch. config.h, on the other hand, will almost
certainly fail to be patched with even any lightly modified

> I will push a cleaner version, including the name change to "keyevent"
> (unless "keypress" is specifically preferred?).

My only feeling is that it may introduce unnecessary merge conflicts,
but I don't think that would be a major problem (they should be easy to
manually resolve, and infrequent in this area).

Received on Wed Feb 26 2014 - 03:47:26 CET

This archive was generated by hypermail 2.3.0 : Wed Feb 26 2014 - 04:00:08 CET