Re: [dev] [ubase] [PATCH] Bring back C89/C90

From: Nick <suckless-dev_AT_njw.me.uk>
Date: Wed, 4 Jun 2014 11:46:18 -0400

Quoth FRIGN:
> Add -pedantic to CFLAGS to spot errors like the one in eject.c.
>
> [snip]
>
> diff --git a/eject.c b/eject.c
> index 7d458e8..62f42fa 100644
> --- a/eject.c
> +++ b/eject.c
> _AT_@ -10,7 +10,7 @@
>
> enum {
> CDROM_EJECT = 0x5309,
> - CDROM_CLOSE_TRAY = 0x5319,
> + CDROM_CLOSE_TRAY = 0x5319
> };
>
> static void

Umm. In what way is the trailing comma an error? Leaving trailing
commas in structs is always reasonable (as far as I know), so you
can move things around / add things without messing with the last
line. Is there some reason you wouldn't want that with this enum?

Or am I missing something?
Received on Wed Jun 04 2014 - 17:46:18 CEST