Re: [dev] [sandy] [PATCH] VIM key bindings.

From: Dimitris Zervas <dzervas_AT_dzervas.gr>
Date: Sun, 13 Jul 2014 18:14:40 +0300

On July 13, 2014 5:50:44 PM EEST, Rafa Garcia Gallego <rafael.garcia.gallego_AT_gmail.com> wrote:
>On Sun, Jul 13, 2014 at 2:40 PM, Dimitris Zervas <dzervas_AT_dzervas.gr>
>wrote:
>>>Great work! I found a couple of bugs, but they should be easy to fix.
>> Add a comment to be able to track them
>
>'m', 'n' and 'N' were not working in command mode (the Arg was 0 so it
>was starting a sequence). I fixed it by creating a stub m_adjective
>and checking for it in code. I pushed that and a couple of extra
>bindings.
Ah, good one.
But, there is a difference between a S_Sentence and a S_Parameter.
a sentence executes the verb with the adj's arg.
a parameter executes the verb with a .v arg same with tge pressed character.
I implemented parameter mode to make multiple marks work.
So, i'll rename m_adjective to m_sentence and create a new m_parameter

>The way of chaining commands if the test pointers for n+1 match is
>brilliant. We need a way to execute those *after* the adjective
>returns so we can easily implement 'y' and 'c'.
We can add a checker. For ex. if .i == 1, as a verb's parameters are completely useless.
if the checker successes, and the tests are the same, carry on executing.

>> Could I have write access to sandy?
>
>Right now I don't have write access to suckless.org either. IMO you
>can have it, but it's up to the suckless.org gods really.
>
>In the meantime I added you to my own bitbucket remote.
Thank you :)
Received on Sun Jul 13 2014 - 17:14:40 CEST