Re: [dev] [patch] sandy

From: Rafa Garcia Gallego <>
Date: Sun, 13 Jul 2014 18:22:23 +0200

On Mon, Jun 30, 2014 at 6:42 AM, <> wrote:
> Subject: [PATCH 1/5] call endwin on suspend
> Subject: [PATCH 2/5] better regcomp failure messages
> Subject: [PATCH 3/5] simplify c file regex
> Subject: [PATCH 4/5] optionalize to use term status feature
> Subject: [PATCH 5/5] possibilize title bar at bottom

Thanks for your contribution. I have applied all but [2/5].

I do like the detailed messages when compiling a regex fails, but:
- I think it can be extended at failed searches as those are, by far,
the ones that will fail most often.
- Actually, if regcomp() fails at f_syntax(), calling i_die() seems
kind of excessive and will lose any changes. I consider this a bug.

This last case should not be a common situation; it will only happen
with a buggy regex in config.h, so thank goodness we don't have a
runtime config file.

As stated before, I don't have access to the git repo at
anymore, but in the meantime you can find the changes at

Sorry for the delay. Please, next time try to attach the patches as
independent files.

Received on Sun Jul 13 2014 - 18:22:23 CEST

This archive was generated by hypermail 2.3.0 : Sun Jul 13 2014 - 18:24:07 CEST