Re: [dev] [PATCH] Reorder-and-extend-glyph-attributes

From: Roberto E. Vargas Caballero <>
Date: Thu, 31 Jul 2014 11:32:11 +0200

> > I think you can find information about them in the same reference that
> > Michael Forney posted.
> Yeah, I just wanted to know if he had another document with different
> behaviors, I’m particularly curious about his cases 21 and 26.

The case 21 was in the code before the patches of Anders, and it is a common
mistake in emulators. Bold face is set with 1, and usually 2x unset
something (for example 2 set italic, and 22 unset it), so it is logical
think that 21 is unset bold, but it is not true.

The case 26 is a bit different, because we implemented fast blinking
with normal blinking, and he sent a patch to have a correct fast
blinking. I have not applied it yet, but I think I am going to apply it.

The problem with fast blinking was that it added more shit to the main loop,
which need a lot of work because I think we agree it is the worse part
of st now.

> It would indeed be better to wait for a confirmation from Anders on this
> before applying the patch of Michael.

I have waited for him more of one month, so I think he is not interested
anymore in his patches that are pending: Add fast blink support,
Refactor the mainloop. I am going to apply the first, but the second
doesn't apply in the HEAD. I don't have time to fix the patch now, so
I will discard it until someone write a new patch that could be applied
to current HEAD.


Roberto E. Vargas Caballero
Received on Thu Jul 31 2014 - 11:32:11 CEST

This archive was generated by hypermail 2.3.0 : Thu Jul 31 2014 - 11:36:06 CEST