Re: [dev] [PATCH] Reorder-and-extend-glyph-attributes

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Thu, 31 Jul 2014 12:10:43 +0200

> I honestly have to say that I don't favor the fast-blinking-patch at
> all. How often do you stumble upon blinking-tags anyway? Even if there
> is a broad application of it in some program I don't know about, I'm
> absolutely sure that the dependency on two blinking speeds is just
> ridiculuous!

Yeah, it is true. I will apply it only if it fits well in the new
main-loop. I have modified the original patch and now it may be applied
to HEAD. The patch itself is not bad, and the complexity it pays for two
blinks is very small. I have not tested it, but I attach it only to show
what modifications need to be done.

> I planned on increasing my efforts to refactor the st main-loop, and
> after only 10 minutes of work, I already had a fix ready for the timing-
> subsystem.

Cool.

> More time spent on it now without unnecessarily bloating it up will open
> the possiblity of getting rid of some cruft.

Refactoring the main loop is the first priority now, if you have a patch
serie about it, be sure no any other patch is going to be applied that
could create a conflict.

Regards,

-- 
Roberto E. Vargas Caballero
Received on Thu Jul 31 2014 - 12:10:43 CEST

This archive was generated by hypermail 2.3.0 : Thu Jul 31 2014 - 12:12:07 CEST