Re: [dev] [PATCH] Reorder-and-extend-glyph-attributes

From: Roberto E. Vargas Caballero <>
Date: Thu, 31 Jul 2014 14:29:09 +0200

> Exactly! Keep it the way it is and just fall through in the switch.
> It's 100 times simpler and it keeps the code lean.

Well, I think is good idea have two flags instead of only one.
If someone really needs two blink modes, he must be able to patch it
easily, and do the or of both flags is not complex.

> Let's do it this way: Everyone who really needs two modes can present
> his opinion here. I'm all for fairness, but while we're discussing this
> topic here, no one really gave a good reason for the two modes.

Of course, I always try to do it in this way ;).

> Take my suggestion: The lowest impact is when you realize which features
> you need and which you don't. Think about it!

This was my original feeling, you can read it in [1].



Roberto E. Vargas Caballero
Received on Thu Jul 31 2014 - 14:29:09 CEST

This archive was generated by hypermail 2.3.0 : Thu Jul 31 2014 - 14:36:08 CEST