Re: [dev] [utmp][PATCH] Use same die() call in parent and child

From: Roberto E. Vargas Caballero <>
Date: Thu, 7 Aug 2014 18:00:37 +0200

> why not immediately initialize the variable?

Uhmmm, yes maybe it is better. I set the value there because I
thought it was better to have all the assignations near between
them, so it was easier to know what was the value of err in
the call to die.

> Also I think this (unmarked!) fallthrough way harder to grasp at the first
> glance. What benefit at all do we get from the patch?

I am used to fallthrough (maybe because I didn't put mark ever),
but maybe is not the same for all the programmers :?.
This patch is more about style that real benefit of the changes. I
usually reuse all the possible paths of a switch to avoid code duplication.


Roberto E. Vargas Caballero
Received on Thu Aug 07 2014 - 18:00:37 CEST

This archive was generated by hypermail 2.3.0 : Thu Aug 07 2014 - 18:12:07 CEST