Re: [dev] [sbase] [PATCH 1/4] tar: Don't crash when get{pw,gr}uid fails

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Sat, 1 Nov 2014 20:57:12 +0000

On Sat, Nov 01, 2014 at 08:36:37PM +0000, Michael Forney wrote:
> - snprintf(h->uname, sizeof h->uname, "%s", pw->pw_name);
> - snprintf(h->gname, sizeof h->gname, "%s", gr->gr_name);
> + snprintf(h->uname, sizeof h->uname, "%s", pw ? pw->pw_name : "");
> + snprintf(h->gname, sizeof h->gname, "%s", gr ? gr->gr_name : "");

The patches look good, thanks!

Just a small clarification on this one, do other tar implementations
do the same here?
Received on Sat Nov 01 2014 - 21:57:12 CET