Re: [dev] fsbm

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Fri, 7 Nov 2014 10:14:09 +0000

On Fri, Nov 07, 2014 at 08:03:01AM +0100, k0ga_AT_shike2.com wrote:
>
> > - Rename volatile bool q = false; to "isrunning".
>
> is.* is a reserved name space, it have not to be used in external scope.
>
>
> > - Use the safer strlcpy or snprintf instead of strcpy().
>
> I disagree, check the size before of calling strcpy. If you want to
> avoid security risk you also have to check the output of strlcpy
> to detect truncations, so you don't win anything. In both cases
> you have to add a comparision, so it is better to use strcpy that
> is standard.

Good luck with that.
Received on Fri Nov 07 2014 - 11:14:09 CET