Re: [dev] [quark] [PATCH] Add the chrootdir configuration variable

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Sat, 29 Nov 2014 20:43:58 +0100

On Sat, Nov 29, 2014 at 7:39 PM, Ivan Delalande <colona_AT_ycc.fr> wrote:
> On Sat, Nov 29, 2014 at 12:21:39PM +0100, Hiltjo Posthuma wrote:
>> On Sat, Nov 29, 2014 at 9:47 AM, Ivan Delalande <colona_AT_ycc.fr> wrote:
>>> On Sat, Nov 29, 2014 at 09:28:24AM +0100, FRIGN wrote:
>>>> Hiltjo told me he was almost done with the changes, so as soon as he
>>>> finishes this masterpiece, I'll merge it into mainline.
>>
>> It needs alot more polish and is not ready for the consumers yet :). I
>> can't give
>> a time when it will be done. I'm also working on other things. I will need to
>> rewrite some parts because they are ugly.
>
> How unpolished is it? If it’s working and doesn’t introduce critical
> bugs or performance issues and if you are not in the middle of a big
> change, I would say that it can be fine to merge.
> There will always be a bunch of people around here more than happy to
> help with polishing and cleaning the code. ;)
>

I would really like to polish it a bit more myself, it is not ready
because there
are big changes coming too. After that code review is definitely welcome :)

>>>> If you like you can check out if the problem still exists in the heavily
>>>> modified branch.
>
> The only one I absolutely need at the moment is the POST method for CGI,
> but all your other improvements are nice and always good to take.
>

Thanks
Received on Sat Nov 29 2014 - 20:43:58 CET