Hi,
* Truls Becken <truls.becken_AT_gmail.com> [2015-01-27 08:57]:
> On Mon, Jan 26, 2015 at 3:23 AM, Troy Sankey <sankeytms_AT_gmail.com> wrote:
> > If an error occurs changing nick (with /n) then it will become out of
> > sync with the server. Here are some of the consequences:
> >
> > * ii will log outgoing messages with the new nick, but others will
> > receive them from the old nick
> > * private messaging breaks
> >
> > Conceivably, this issue is common on large networks where there is a
> > high likelihood of nick collisions. I noticed it on my own server where
> > the maximum nick length is 9 characters, and I accidentally exceeded
> > that.
> >
> > This patch removes the /n command, making /NICK the only way to change
> > the nick. This could make people angry, what do you think? /me doesn't
> > think there are many people using ii, so it won't make many people
> > angry :-)
> >
> Alternatively, /n could still send NICK, but not prematurely set the variable.
Thanks for the report, this is definitely a problem. If possible, I'd like to
prevent dropping /n mostly for compatibility reasons and making sure that
basic IRC functionality is still provided by short commands.
What I think may be better would be to only set nick after a successful NICK
message was received from the network as Truls suggests.
Would you mind testing the attached patch?
Cheers
Nico
--
Nico Golde - XMPP: nion_AT_jabber.ccc.de - GPG: 0xA0A0AAAA
- application/pgp-signature attachment: stored
Received on Wed Jan 28 2015 - 20:44:52 CET