Re: [dev] [surf] [PATCH] allow buttonrelease customization in config.h

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Tue, 10 Feb 2015 19:07:34 +0100

Greetings.

On Tue, 10 Feb 2015 19:07:34 +0100 Markus Teich <markus.teich_AT_stusta.mhn.de> wrote:
> Heyho,
>
> here is my atempt to Christophs proposal. There are a few rough edges though:
>
> * On my mouse buttons 8 and 9 are used for the prev/next navigation. I thought 4
> and 5 would be standard, but could not test with another mouse. I forgot to
> remove the printf statement in buttonrelease(), so you can still test your
> mouse buttons.
> * The differentiation between embedding or not embedding is kind of ugly with
> two very similar functions.
> * The passing of the link url to the handler function is also very hacky.

I've applied the patch so far. Of course without the debug print. Thanks for
sending it in.


Sincerely,

Christoph Lohmann
Received on Tue Feb 10 2015 - 19:07:34 CET

This archive was generated by hypermail 2.3.0 : Tue Feb 10 2015 - 19:12:10 CET