Re: [dev] [st] crash on font resize (patch inside)

From: Nils Reuße <ml_AT_hxgn.net>
Date: Sun, 15 Feb 2015 11:05:31 +0100

On 15.02.2015 11:01, k0ga_AT_shike2.com wrote:
>
>> diff --git a/st.c b/st.c
>> index 1deb7bc..547ddc9 100644
>> --- a/st.c
>> +++ b/st.c
>> _AT_@ -2992,7 +2992,7 @@ xloadfonts(char *fontstr, double fontsize) {
>> if(!pattern)
>> die("st: can't open font %s\n", fontstr);
>>
>> - if(fontsize > 0) {
>> + if(fontsize > 1) {
>> FcPatternDel(pattern, FC_PIXEL_SIZE);
>> FcPatternDel(pattern, FC_SIZE);
>> FcPatternAddDouble(pattern, FC_PIXEL_SIZE,
>> (double)fontsize);
>
> I like more this patch, and it is the version I am going to apply.
>
> Regards,
>

Thanks! While you're at it, you could bump the copyright note as well.

Best,
Nils


diff --git a/st.c b/st.c
index 1deb7bc..b9d30a7 100644
--- a/st.c
+++ b/st.c
_AT_@ -3938,7 +3938,7 @@ run(void) {

  void
  usage(void) {
- die("%s " VERSION " (c) 2010-2014 st engineers\n" \
+ die("%s " VERSION " (c) 2010-2015 st engineers\n" \
         "usage: st [-a] [-v] [-c class] [-f font] [-g geometry] [-o
file]\n"
         " [-i] [-t title] [-w windowid] [-e command ...]\n",
argv0);
  }
Received on Sun Feb 15 2015 - 11:05:31 CET