Re: [dev] [dwm] [dmenu] The Xft situation

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Thu, 5 Mar 2015 08:32:47 +0100

Hi there,

On 5 March 2015 at 02:36, Eric Pruitt <eric.pruitt_AT_gmail.com> wrote:
> On Wed, Mar 04, 2015 at 12:09:23PM -0800, Eric Pruitt wrote:
>> If you're going to use the patch I submitted to the wiki with fallback
>> font support, don't -- I fixed a couple of non-critical bugs I found
>> after I submitted the patch to the wiki, but I didn't bother to send in
>> a new patch since my old one hadn't been approved yet. I can post the
>> updated patch to this thread in ~6 hours if you guys do intend to use
>> the code I wrote.
>
> I've attached the updated patch to this email.

Thanks for the patch. In general I would be ok with it, but I have a
couple remarks that block me from applying it in its current state:

1. First of all libs/drw.{h,c} are the primary version of drw -- which
would require a separate patch.

2. In drw.h you change drw_font_create() that now brings in some
FcPattern *fontpattern argument, which breaks the font-agnostics of
drw. Right now the only allowed X11 specific type used by drw is
Window.

If you come up fixing those issues, I will apply it to both libsl and dwm.

The next step afterwards is replacing the old(er) draw.{c,h} with
libsl/drw.{c,h} in dmenu. I will do that.

Thanks and best regards,
Anselm
Received on Thu Mar 05 2015 - 08:32:47 CET