Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Mon, 18 May 2015 21:31:22 +0200

On Sun, May 17, 2015 at 01:18:26PM +0200, Marc André Tanner wrote:
> I have commited a couple of patches which should implement this
> functionality as described in another mail (i.e. without allocating
> a temporary buffer).

I like the use of do-while/select! It reminds me of the for/select
construct often used to select from channels in Go and I did not think
of using C's select in that way.


> Unfortunately they are only minimaly tested (I should really spend
> my time on some university related projects).

I did some light testing and the only issue I could find is that the
undo-function is behaving strangely.

If a do a :s/asdf/ASDF/g on a file containing 120'000 lines consisting
of something like 'asdfasdfasdf' and then press 'u' to undo the change,
the original text lines are being inserted again while the changed ones
are not deleted (completely?) resulting in about a doubling of the lines
in the file.

I will try to find the time to debug it.
Received on Mon May 18 2015 - 21:31:22 CEST