Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

From: Marc André Tanner <>
Date: Tue, 23 Jun 2015 13:10:53 +0200

On Wed, May 27, 2015 at 06:53:11PM +0200, Silvan Jegen wrote:
> On Mon, May 18, 2015 at 10:28:06PM +0200, Marc André Tanner wrote:
> > On Mon, May 18, 2015 at 09:31:22PM +0200, Silvan Jegen wrote:
> > > I did some light testing and the only issue I could find is that the
> > > undo-function is behaving strangely.
> >
> > Yes I noticed this too. At some point while writing the patches I also
> > managed to trigger a segfault when redoing stuff. Might be a more
> > general problem although in general the editor seemed rather stable
> > during daily usage ...
> When tracing I found that the text_range_write function in cmd_filter
> creates a text snapshot when called. If I uncomment this call to
> text_snapshot (and the write to txt->saved_action), undoing the whole
> filter operation works but re-doing it is broken (the re-doing seems to be
> broken in other cases as well though). Uncommenting this text_snapshot
> function call may also have other consequences for other codepaths
> though so I will need more time to see whether there is another way to
> make undo work.

Taking a snapshot in text_range_write is definitely a bug, it was
done there under the assumption that the function is only ever called
when saving the file. However this is no longer the case ...

 Marc André Tanner >< >< GPG key: CF7D56C0
Received on Tue Jun 23 2015 - 13:10:53 CEST

This archive was generated by hypermail 2.3.0 : Tue Jun 23 2015 - 13:12:19 CEST