Re: [dev] [ii] [PATCH] keep nick synchronized with server

From: Nico Golde <nico_AT_ngolde.de>
Date: Thu, 5 Nov 2015 13:24:47 +0100

Hi,
* Troy Sankey <sankeytms_AT_gmail.com> [2015-01-29 04:12]:
> On 2015-01-28 14:44:52 -0500, Nico Golde wrote:
> > What I think may be better would be to only set nick after a successful NICK
> > message was received from the network as Truls suggests.
> > Would you mind testing the attached patch?
>
> Tested, works. Can we still make it log to the network channel, even
> after a success? (1) it is positive confirmation which helps the user
> understand what's going on, (2) I think if somebody wrote an ii wrapper
> which depended on that message, then this change would break it, and (3)
> it makes implementing an ii wrapper easier (which is something I was
> intending to do).

Sorry for the blast from the past... but pushed :)

Cheers,
Nico
-- 
Nico Golde - XMPP: nion_AT_jabber.ccc.de - GPG: 0xA0A0AAAA

Received on Thu Nov 05 2015 - 13:24:47 CET

This archive was generated by hypermail 2.3.0 : Thu Nov 05 2015 - 13:36:09 CET