Re: [dev] [sbase][RFC] patch: whitespace patches

From: FRIGN <dev_AT_frign.de>
Date: Thu, 25 Feb 2016 13:37:49 +0100

On Thu, 25 Feb 2016 13:29:07 +0100
v4hn <me_AT_v4hn.de> wrote:

Hey v4hn,

> Sounds useless to me. What counts as whitespace change?
> `if(x){ \n` -> `if(x){\n`, ok,
> `\tif(x){\n` -> ` if(x){\n`, in python and haskell probably not,
> `if(x){\n` -> `if(x) {\n`, seems simple enough,
> `printf("%d",x);\n` -> `printf("% d",x);\n`, that's no simple whitespace change,
> not to talk about the infamous bumblebee patch
> `rm -rf /usr /share` -> `rm -rf /usr/share`
>
> This does not belong into standard patch.

this is a very good point.

> > Yes it would be nice to support a dry run flag regardless of
> > whether -w is specified or not.
> gnu patch supports --dry-run. It probably makes sense
> to support this flag either way.

No long-opts please.

Cheers

FRIGN

-- 
FRIGN <dev_AT_frign.de>
Received on Thu Feb 25 2016 - 13:37:49 CET

This archive was generated by hypermail 2.3.0 : Thu Feb 25 2016 - 13:48:12 CET