Re: [dev] svmidi - a simple virtual midi keyboard (WIP)

From: Johnny Oskarsson <joskar_AT_joskar.se>
Date: Thu, 7 Apr 2016 03:26:09 +0200

Hi,

I see now that 135da56cc and a338e9611 introduced an `undefined reference
to midisend' when using ALSA. (since I was using a macro for that function,
which became redundant with commit 135da56cc and removed in a338e9611)

Furthermore, I have also attached my patch for a 'clean build' on Linux
(glibc). For some reason _POSIX_C_SOURCE needs to be defined in order for
getopt(3) to be included from unistd.h. A few typedefs were not defined
before being used, and as mentioned earlier, u_char was not defined at
all on my system.
Also, "util.h" does not seem to be part of the repository, but I
can't find any missing functionality without it.

I have attached both patches.

Regards,

Johnny Oskarsson

On Wed, Apr 06, 2016 at 09:08:49PM -0300, Henrique N. Lengler wrote:
> On Wed, Apr 06, 2016 at 10:33:23PM +0200, Johnny Oskarsson wrote:
> > Hi,
> > First of all I would like to thank you for this! I use VMPK quite
> > a lot and it is nice to see a "simpler" alternative without all the
> > dependencies.
>
> Hi,
>
> Nice to hear.
>
> > > The biggest missing feature is ALSA support, which I can't do
> > > since I have no linux box, but might be extremely simple task.
> > > Once the support is added, the software can be quite useful, in
> > > such a small piece of code.
> >
> > I added basic support for ALSA, which works on my machine at least. See
> > attached patch.
> > (fair warning: I haven't used the ALSA sequencer API before)
> >
> > There seems to be some BSD-specific things in your code (u_char, for
> > instance) which I had to change to make svmidi compile, but I haven't
> > included this in the patch since it would distract from the ALSA
> > support itself.
> >
> > Cheers,
> >
> > Johnny
>
> So your patch looks fine, I applied it, did a simple change, and pointed in
> TODO that it needs more testing, as the whole software do.
>
> By now, thanks for helping.
>
> --
> Regards,
>
> Henrique N. Lengler
>

Received on Thu Apr 07 2016 - 03:26:09 CEST